Re: [RFC: 2.6 patch] let GROUP_SCHED depend on BROKEN

From: Mike Galbraith
Date: Tue May 27 2008 - 05:47:50 EST



On Tue, 2008-05-27 at 11:58 +0300, Adrian Bunk wrote:

> Once it is feature complete and then got the usual testing through
> -next I'll have no objections against offering it again to users.
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
>
> ---
> c67cfbbb40895b72760865527dd1949631b1d183 diff --git a/init/Kconfig b/init/Kconfig
> index d9526b5..564deba 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -333,7 +333,7 @@ config HAVE_UNSTABLE_SCHED_CLOCK
>
> config GROUP_SCHED
> bool "Group CPU scheduler"
> - depends on EXPERIMENTAL
> + depends on BROKEN
> default n
> help
> This feature lets CPU scheduler recognize task groups and control CPU

FWIW, here's my NAK, and the grounds therefore: Group scheduling
clearly fits the current criteria for CONFIG_EXPERIMENTAL. In-tree
development is a necessary fact of life, and has always been a fact of
life. IMO, your attempt to change the rules is seriously misguided.

<quote>
config EXPERIMENTAL
bool "Prompt for non-development and/or absolutely complete code/drivers"
---help---
Some of the various things that Linux supports (such as network
drivers, file systems, network protocols, etc.) can be in a state
of development where the functionality, stability, or the level of
testing is not yet high enough for general use. This is usually
known as the "alpha-test" phase among developers. If a feature is
currently in alpha-test, then the developers usually discourage
uninformed widespread use of this feature by the general public to
avoid "Why doesn't this work?" type mail messages. However, active
testing and use of these systems is welcomed. Just be aware that it
may not meet the normal level of reliability or it may fail to work
in some special cases. Detailed bug reports from people familiar
with the kernel internals are usually welcomed by the developers
(before submitting bug reports, please read the documents
<file:README>, <file:MAINTAINERS>, <file:REPORTING-BUGS>,
<file:Documentation/BUG-HUNTING>, and
<file:Documentation/oops-tracing.txt> in the kernel source).

This option will also make obsoleted drivers available. These are
drivers that have been replaced by something else, and/or are
scheduled to be removed in a future kernel release.

Unless you intend to help test and develop a feature or driver that
falls into this category, or you have a situation that requires
using these features, you should probably say N here, which will
cause the configurator to present you with fewer choices. If
you say Y here, you will be offered the choice of using features or
drivers that are currently considered to be in the alpha-test phase.
</quote>

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/