Re: 2.6.26: x86/kernel/pci_dma.c: gfp |= __GFP_NORETRY ?

From: Andi Kleen
Date: Sun May 25 2008 - 12:27:51 EST


> So how about linux-2.6.26-gfp-no-oom.patch (see previous mail) for
> 2.6.26

Changing the gfp once globally like you did is not right, because
the different fallback cases have to be handled differently
(see the different cases I discussed in my earlier mail)

Especially the 16MB zone allocation should never trigger the OOM killer.

That could be special cased, but __GFP_NO_OOM_KILLER is likely better
as a short term fix although I'm still not 100% sure what implications
it will have to do more VM replies in the early fallbacks.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/