Re: [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix

From: Oliver Endriss
Date: Tue May 13 2008 - 20:56:47 EST


Ingo Molnar wrote:
>
> * Oliver Endriss <o.endriss@xxxxxx> wrote:
>
> > Sure. And without the patch you can simply add
> > - STANDALONE=y or
> > - DVB_AV7110_FIRMWARE=n
> > to your allrandom.config. ;-)
>
> hm, you are right - i've added STANDALONE=y previously but it went
> missing in action. So forget my patch, it was user error - the driver is
> right in that it already depends on STANDALONE :-)

Ok. I already wondered why this issue came up now.
The dependencies of DVB_AV7110_FIRMWARE did not change during the last
4 years...

> I guess STANDALONE
> should enable PREVENT_FIRMWARE_BUILD as well to avoid such errors ...

Yes, it does not make much sense to build the firmware if the driver
will not be compiled anyway.

CU
Oliver

--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/