Re: [PATCH 0/3] ia64: Migrate data off physical pages with correctable errors v3

[Russ Anderson]

On Fri, May 09, 2008 at 08:21:32AM -0700, Linus Torvalds wrote:
> On Fri, 9 May 2008, Russ Anderson wrote:
> > 
> >   [2/3] page.discard.v2: Avoid putting a bad page back on the LRU.
> > 
> > 	page.discard are the arch independent changes.  It adds a new
> > 	page flag (PG_memerror) to mark the page as bad and prevent it
> > 	from being put back on the LRU.  PG_memerror is only defined
> > 	on 64 bit architectures. 
> 
> So I haven't looked at this a lot, but it strikes me that it look to be 
> much simple if you were to just increment the page count instead of 
> playing games in mm/page_alloc.c.

Looking closer at the code, it is possible to increment the page count
and avoid playing games in mm/page_alloc.c.  The page count cannot
be directly incremented, due to the way the migration code works, but,
as Christoph pointed out, the migration code increments the page count.
Preventing the bad pages from being returned to the LRU prevents
the reference counts from going to zero.  The net effect is as you
suggest.
 
> That will make sure that it never goes back on any free lists, and 
> requires no changes to the allocator. Hmm?

All the pages on the bad page list have a reference count of 1.

> I'm also not really seeing why this triggers on lru_cache_add(), since 
> that should only happen to new pages anyway. Who does lru_cache_add() on 
> old pages?

The change to lru_cache_add() is being removed.  I'll post the
updated patches shortly.

> 			Linus

-- 
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          rja@xxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/