Re: [PATCH 0/3] ia64: Migrate data off physical pages with correctableerrors v3

[Christoph Lameter]

On Fri, 9 May 2008, Linus Torvalds wrote:

> So I haven't looked at this a lot, but it strikes me that it look to be 
> much simple if you were to just increment the page count instead of 
> playing games in mm/page_alloc.c.

We are taking a refcount when isolating the page from the LRU. The 
problem is that the migration code attempts to free the page. That code 
could be changed to do something else instead like putting the page on the 
bad list.
 
> I'm also not really seeing why this triggers on lru_cache_add(), since 
> that should only happen to new pages anyway. Who does lru_cache_add() on 
> old pages?

Migration code does the adding back to the LRU when migration is complete. 
So he hooked into that I guess.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/