Re: [patch 1/2] x86: head_64.S cleanup - use straight move to CR4register

[H. Peter Anvin]

Cyrill Gorcunov wrote:
> There is no need for testing the values because we already know
> what they should be. Just set them in straight way.

He isn't testing them, he's setting individual bits.

Either of these is pretty silly; the right way to do this is:

	movl	$(X86_CR4_PAE|X86_CR4_PGE), %eax
	movq	%rax, %cr4

A movl in 64-bit mode zero extends.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/