Re: [PATCH] riscom8: remove redundant null pointer test

From: Alan Cox
Date: Mon May 12 2008 - 16:11:50 EST


On Mon, 12 May 2008 19:27:10 +0100
Chris Malley <mail@xxxxxxxxxxxxxxxxx> wrote:

> tty has already been dereferenced at least twice in these functions,
> so checking for null here seems a bit unnecessary.

Oh it is - and lots of the other tty checks are bogus too.

Acked-by: Alan Cox <alan@xxxxxxxxxx>

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/