Re: [PATCH] call_usermodehelper_setup() should use GFP_KERNEL

From: KOSAKI Motohiro
Date: Thu May 08 2008 - 03:31:56 EST


> KOSAKI Motohiro wrote:
> > Now, call_usermodehelper_setup() use GFP_ATOMIC.
> > but it is slighly odd.
> > because call_usermodehelper() is always called process context.
> >
>
> Are you sure? I found the following call chain:
>
> static irqreturn_t power_handler(int irq, void *dev_id)
> ->orderly_poweroff(true);
> ->call_usermodehelper_setup()

sorry, you are right.
I'll make patch again.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/