Re: sparc64 bootup regression...

From: KAMEZAWA Hiroyuki
Date: Wed Apr 30 2008 - 03:29:00 EST


On Wed, 30 Apr 2008 00:25:30 -0700 (PDT)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> Date: Wed, 30 Apr 2008 16:15:40 +0900
>
> > How about this ? If this is messy (or doesn't work), Goto-san will rework
> > his own patch by himself. (this patch is against -mm but I think no HUNK to
> > git tree)
>
> This makes the original change pointless.
>
It seems the orignal change expects NODE_DATA() is allocated at boottime.
not in .bss section.

> If the goal is to put the usemap in the same section as the memory
> itself, in order to allow for it to be freed during memory hotplug,
> this new change just makes the facility not work some of the time.
>
yes, at least, WARNING is necessary.

> Now maybe sometimes it will work, maybe sometimes it will not.
>
> It's not the end of the world if this change is reverted for a few
> days while we work out what to do about this.
>
yes ;)

> Really, it does not reflect badly upon you or Goto-san, if the change
> is reverted temporarily.
>
Okay, I agree to revert it.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/