Re: [PATCH] x86: !x & y typo in mtrr code

[Björn Steinbrink]

On 2008.04.29 23:04:35 +0200, Ingo Molnar wrote:
> 
> * Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Sat, Apr 26, 2008 at 09:00:17PM -0700, Harvey Harrison wrote:
> > > As written, this can never be true.
> > 
> > ... and introduced through x86.git, of all things...  May I suggest 
> > that in addition to all-important whitespace hunting something that 
> > catches lowly real bugs would also be run over that tree?  sparse 
> > *does* catch that...
> 
> firstly, it _was_ caught via Sparse, ...

But that is exactly Al's point. Had you run sparse over your tree
_before_ it got pulled by Linus, that bug should have never made it into
mainline.

Björn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/