Re: [PATCH] x86: !x & y typo in mtrr code

[Ingo Molnar]

* Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> On Sat, Apr 26, 2008 at 09:00:17PM -0700, Harvey Harrison wrote:
> > As written, this can never be true.
> 
> ... and introduced through x86.git, of all things...  May I suggest 
> that in addition to all-important whitespace hunting something that 
> catches lowly real bugs would also be run over that tree?  sparse 
> *does* catch that...

firstly, it _was_ caught via Sparse, secondly, if you check the code 
flow, the bug - while indeed ugly looking - was harmless and had no 
side-effects. That's why it didnt trigger in testing.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/