Re: [patch] pcspkr: fix dependancies

From: Stas Sergeev
Date: Tue Apr 29 2008 - 15:57:19 EST


Hello.

Sam Ravnborg wrote:
> If you google you will find a long thread about this patch.
Yes, indeed, thankyou.
http://kerneltrap.org/mailarchive/linux-kernel/2008/1/17/577151

> It is all about saving memory for embedded platforms.
OK. This wasn't clear from the log
message for some reason, but it is
said in the above thread.

> No need to have the driver if there is no speaker on the board.
Very probably, and for that case I
made the patch like this:
http://uwsg.ucs.indiana.edu/hypermail/linux/kernel/0804.3/1189.html

> Ask Michael (author) if you need more info.
Reading the thread, it actually seems
like Michael wanted to submit the patch
much like the aforementioned one of
mine:
http://kerneltrap.org/mailarchive/linux-kernel/2008/1/18/580583
but haven't done so in time, and as the
result, the wrong one stuck in.
But this is never too late to correct, I
hope.

So I see 2 options: either revert the
patch completely, or revert the dependancies
like Michael suggested initially (if I
understand his suggestion right).
Both patches are here, in this thread.
Thoughts?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/