Re: kvm: how big is type?

From: Izik Eidus
Date: Mon Apr 28 2008 - 11:32:19 EST


Avi Kivity wrote:
> Harvey Harrison wrote:
>> arch/x86/kvm/x86.c:3484:25: warning: cast truncates bits from constant
>> value (100 becomes 0)
>> arch/x86/kvm/x86.c:3510:24: warning: cast truncates bits from constant
>> value (100 becomes 0)
>>
>> The problem:
>> cseg_desc.type &= ~(1 << 8); //clear the B flag
>> nseg_desc.type |= (1 << 8);
>>
>> type is a 4-bit bitfield on x86....please look into this.
>>
>>
>
> I think it ought to be (1 << 1), not (1 << 8), as it refers to the
> "busy" bit of the task type. Izik?
>
>