Re: kvm: how big is type?

From: Avi Kivity
Date: Mon Apr 28 2008 - 07:44:24 EST


Harvey Harrison wrote:
arch/x86/kvm/x86.c:3484:25: warning: cast truncates bits from constant value (100 becomes 0)
arch/x86/kvm/x86.c:3510:24: warning: cast truncates bits from constant value (100 becomes 0)

The problem:
cseg_desc.type &= ~(1 << 8); //clear the B flag
nseg_desc.type |= (1 << 8);

type is a 4-bit bitfield on x86....please look into this.


I think it ought to be (1 << 1), not (1 << 8), as it refers to the "busy" bit of the task type. Izik?


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/