Re: [patch] x86, voyager: fix ioremap_nocache()

From: David Miller
Date: Sun Apr 27 2008 - 18:58:48 EST


From: "H. Peter Anvin" <hpa@xxxxxxxxx>
Date: Sun, 27 Apr 2008 15:52:02 -0700

> Arguably, the right thing is to not even have ioremap() anymore, just
> ioremap_{cache,nocache,wc} and consider any unconverted ioremap() as a
> flag to audit that particular piece of code.
>
> I don't think that can be done "instantly", though, so defaulting
> ioremap() to uncached (as it apparently has been on other arches
> already?) is the conservative option in the meantime.

I think this is a reasonable course of action.

That leaves one of Jeff's concerns, what to do with pci_iomap(). That
was designed to give mappings with caching enabled, and as a result we
probably should make it behave that way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/