Re: [git pull] generic bitops

[Harvey Harrison]

On Thu, 2008-04-24 at 15:14 -0700, Linus Torvalds wrote:
> 
> On Thu, 24 Apr 2008, Ingo Molnar wrote:
> >
> > this started out as improvements/generalizations to x86 bitops, but grew 
> > generic impact (and generic optimizations) as well, so it's offered as a 
> > separate tree.
> 
> Can you do the config thing differently?
> 
> > diff --git a/arch/um/Kconfig.i386 b/arch/um/Kconfig.i386
> > index e09edfa..49990ea 100644
> > --- a/arch/um/Kconfig.i386
> > +++ b/arch/um/Kconfig.i386
> > @@ -39,6 +39,14 @@ config ARCH_REUSE_HOST_VSYSCALL_AREA
> >  	bool
> >  	default y
> >  
> > +config GENERIC_FIND_FIRST_BIT
> > +	bool
> > +	default y
> > +
> > +config GENERIC_FIND_NEXT_BIT
> > +	bool
> > +	default y
> > +
> 
> .. because instead of having each architecture do these kinds of things, 
> we're trying to make the *generic* code (ie lib/Kconfig) do
> 
> 	config GENERIC_FIND_FIRST_BIT
> 		bool
> 		default n

config HAVE_GENERIC_FIND_FIRST_BIT
	def_bool n

(I know it defaults to n, but this pattern is becoming suggestive of
features that must be selected, in addition to the HAVE_ prefix)

Although I think for lib stuff, we may want to think about WANT_
prefixes to suggest you have to opt in.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/