Re: [PATCH -mm 2/2] send_sigqueue: don't forget about handle_stop_signal()

From: Roland McGrath
Date: Thu Mar 06 2008 - 06:06:25 EST


> send_group_sigqueue() calls handle_stop_signal(), send_sigqueue() doesn't.
> This is not consistent and in fact I'd say this is (minor) bug.

Yes, it was wrong. I think I noticed it long ago and never bothered with
it because send_sigqueue is nearly unused. SIGEV_THREAD_ID is in practice
only used internally by libc (timer_create) to implement SIGEV_THREAD, and
it never uses any of the signals handle_stop_signal checks for.

Your fix is good and should go in.
I'd bet noone will ever notice the difference now or ever.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/