Re: [PATCH 2.6.24] mm: BadRAM support for broken memory

[KOSAKI Motohiro]

Hi Rick

> > >  +#define PG_badram              20      /* BadRam page */
> > 
> > some architecture use PG_reserved for treat bad memory.
> > Why do you want introduce new page flag?
> 
> It is clearer to properly name a flag, I suppose.
> Is the use that you are mentioning the intended, and only use of the flag?
> If not, I think it is clearer to use a separate flag instead of overloading
> one.

hmmm
unfortunately flag bit of struct page is very valuable resource
rather than diamond on current implementaion ;-)

if you can change to no introduce new page flag,
IMHO merge to mainline dramatically become easy.


> > for show_mem() improvement?
> 
> For code clarity.

agreed with your code is clarify. but...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/