Re: usb/serial/io_ti.c: inconsequent NULL checking

From: Alan Cox
Date: Fri Feb 22 2008 - 05:20:10 EST


> Either the test of port->tty here is unneeded:
>
> if (port->tty)
> port->tty->low_latency = low_latency;
>
> ...or the lack of test of port->tty here is a mistake:
>
> edge_set_termios (port, port->tty->termios);

Interesting - so coverity doesn't understand the BKL. It's producing the
right answer, for the right reason but the assumption it makes isn't 100%
safe.

The check can go.

Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/