Re: usb/serial/io_ti.c: inconsequent NULL checking

From: Ray Lee
Date: Tue Feb 19 2008 - 18:39:20 EST


On Feb 19, 2008 3:25 PM, Greg KH <gregkh@xxxxxxx> wrote:
> On Wed, Feb 20, 2008 at 12:49:15AM +0200, Adrian Bunk wrote:
> > The Coverity checker spotted the following inconsequent NULL checking
> > introduced by commit d5f5bcd425b771c0b7ff5a650b2ce061ac8bbb87:
> >
> > <-- snip -->
>
> It's not a real problem, that pointer can't go away.

I think he meant inconsistent not "inconsequent."

Either the test of port->tty here is unneeded:

if (port->tty)
port->tty->low_latency = low_latency;

...or the lack of test of port->tty here is a mistake:

edge_set_termios (port, port->tty->termios);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/