Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters toatomics

From: Corey Minyard
Date: Wed Feb 20 2008 - 10:41:26 EST


Matt Domsch wrote:
On Thu, Feb 14, 2008 at 12:30:51PM -0600, Corey Minyard wrote:
From: Konstantin Baydarov <kbaidarov@xxxxxxxxxxxxx>

Atomics are a lot more efficient and neat than using a lock.

per_cpu variables are a lot more efficient and neat than using locks
for simple statistics. no cache line bouncing to increment the
counter. Are these read so often that atomics are really better?
I agree, I'll put this in the plan for the future. I don't have time to do it at this point, but the changes made in these patches should make it easy to change in the future.

Thanks,

-corey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/