arch/x86/kernel/vsyscall_64.c: overeager NOP of syscalls

From: Arne Georg Gleditsch
Date: Wed Feb 20 2008 - 09:26:36 EST


Hi,

I'm looking at 2.6.25-rc2. vsyscall_sysctl_change contains code to NOP
out the actual system call instructions of the vsyscall page when
vsyscall64 is enabled. This seems to interact badly with the fallback
code in do_vgettimeofday which tries to call gettimeofday if the
configured clock source does not support vread. (In effect,
gettimeofday() becomes a nop and time() always returns 0. Not very
useful.)

Is there a good reason to keep this? Aren't the instructions in
question avoided (or invoked) according to the vsyscall64 flag by the
surrounding logic anyway?

--
Arne.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/