Re: [patch] suspend/resume self-test

[David Brownell]

On Tuesday 19 February 2008, Ingo Molnar wrote:
> * Pavel Machek <pavel@xxxxxx> wrote:
> 
> > > Thing is, this will catch not just regressions ... but cases where 
> > > STR never worked in the first place.  Video problems, etc.  Also 
> > > various system startup races, as in the PCMCIA and MMC/SD/SDIO cases 
> > > I noted.
> > 
> > David is right here. At minimum, s2ram needs acpi_sleep=... options to 
> > tell it how to set up the video. That is not issue for you, but it 
> > means we should not be doing it by default.
> 
> nowhere did i suggest that it should be default-enabled ...

The patch you asked to be merged *DID* have it be default-enabled!
So you did more than just "suggest"... if that option is enabled in
Kconfig, this test is always forced on and it will cause failures
on systems where STR has never worked.

The patch comments even pointed out that flaw.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/