[BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable IRQ feature not functional for handle_simple_irq

From: Hennerich, Michael
Date: Tue Feb 19 2008 - 05:25:36 EST


Thomas,

I have reasonable doubt that the delayed disable feature on linux-2.6.24 for handle_simple_irq is broken.

In 2.6.22 there was something like this:

if (unlikely(!action || (desc->status & IRQ_DISABLED))) {
if (desc->chip->mask)
desc->chip->mask(irq);
...

However in 2.6.24 the "DISABLED" IRQ in case it happens is never going to be masked.

if (unlikely(!action || (desc->status & IRQ_DISABLED)))
goto out_unlock;


I see a disabled IRQ being invoked in an endless loop.

-Michael

------------------------------------------------------------------
********* Analog Devices GmbH michael.hennerich@xxxxxxxxxx
** ***** Systems Engineering
** ** Wilhelm-Wagenfeld-Strasse 6
** ***** D-80807 Munich
********* Germany
Registergericht München HRB 40368, Geschäftsführer: Thomas Wessel, Vincent Roche, Joseph E. McDonough
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/