Re: [git patches] IDE updates (part 2)

[Benjamin Herrenschmidt]

On Sun, 2007-10-14 at 00:41 +0200, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 14 October 2007, Alan Cox wrote:
> > > > > 		/* Probably a PCI interface... */
> > > > > 		for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i)
> > > > > 			hw->io_ports[i] = data_port + i - IDE_DATA_OFFSET;
> > > > > 		hw->io_ports[IDE_CONTROL_OFFSET] = ctrl_port;
> > 
> > Ok so in actual fact
> > 
> > - The piece of code above can't be executed anyway
> > - The ctrl_port argument is not needed ?
> 
> pmac_ide_init_hwif_ports() is also called by ide_init_hwif_ports()
> through ppc_ide_md.init_hwif.

In which case it should be called with a ctrl_port right ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/