Re: [git patches] IDE updates (part 2)

From: Bartlomiej Zolnierkiewicz
Date: Sat Oct 13 2007 - 18:36:30 EST


On Sunday 14 October 2007, Alan Cox wrote:
> > > > /* Probably a PCI interface... */
> > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i)
> > > > hw->io_ports[i] = data_port + i - IDE_DATA_OFFSET;
> > > > hw->io_ports[IDE_CONTROL_OFFSET] = ctrl_port;
>
> Ok so in actual fact
>
> - The piece of code above can't be executed anyway
> - The ctrl_port argument is not needed ?

pmac_ide_init_hwif_ports() is also called by ide_init_hwif_ports()
through ppc_ide_md.init_hwif.

Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/