Re: missing mnt_drop_write() on open error

From: Miklos Szeredi
Date: Wed Sep 26 2007 - 14:59:30 EST

> > Btw, may_open() doesn't do mnt_want_write() around the truncation if
> > file is opened with O_TRUNC | O_RDONLY.
> What's the path to may_open() in that case? open_namei() should wrap
> all callers other than nfs, and it does:
> /* O_TRUNC implies we need access checks for write permissions */
> if (flag & O_TRUNC)
> acc_mode |= MAY_WRITE;
> Which should trigger the may_open() code.

Ah, I missed that.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at