kbuild: LDFLAGS_MODULE unusable for external module builds (2.6.23-rc2)

From: Henry Nestler
Date: Tue Sep 25 2007 - 05:49:59 EST

In reference of git 114f51577724b782a30f4f5ceaee9880de93d776:
kbuild: use LDFLAGS_MODULE only for .ko links
Sam Ravnborg pointed out that Documentation/kbuild/makefiles.txt already
says this is what it's for. This patch makes the reality live up to the
documentation. This fixes the problem of LDFLAGS_BUILD_ID getting into too
many places.

LDFLAGS_MODULE is not usable in module build out of kernel tree since
2.6.23-rc2. LDFLAGS_$@ should use, but does never work. - Not for
external module builds with the option "M=..."

What macro should set for linker parameters of foo.o ? I'm not shure.
Currently found, that only LDFLAGS is usable. But, found LDFLAGS in
modpost calls, there also exist a --start-group/--end-group. Is it right
to use it for external module?

Here examples and the outputs. Host and target is an i686 SMP Linux.

mkdir /tmp/test; cd /tmp/test
cat >Makefile <<EOF
obj-m := name.o
name-objs := foo.o
# Use multipe defines, hope any would work
LDFLAGS_MODULE += --start-group
LDFLAGS_name += --start-group
LDFLAGS_name.o += --start-group

cat >foo.c <<EOF
#include <linux/module.h>
#include <linux/init.h>
int init_module(void) {return 0;}
void cleanup_module(void) {return;}

#2.6.22 works. LDFLAGS_MODULE was used:
make V=1 -C src/linux-2.6.22 M=$PWD | grep " ld "
ld -m elf_i386 -m elf_i386 -r --start-group -o /tmp/name.o /tmp/foo.o
ld -m elf_i386 -m elf_i386 -r -o /tmp/name.ko /tmp/name.o /tmp/name.mod.o

#2.6.23-rc7 does not work. Nothing from LDFLAGS can seen in linker line:
make V=1 -C src/linux-2.6.23-rc7 M=$PWD | grep " ld "
ld -m elf_i386 -m elf_i386 -r -o /tmp/name.o /tmp/foo.o
ld -m elf_i386 -r -m elf_i386 -o /tmp/name.ko /tmp/name.o

Perhaps anybody can give better idea for Makefile with
recursive depens of libraries? What I'm missing, is a setup for
--start-group AND the --end-group arrount the lib.a files. Currently --start-groups is somether before the first object and has no --end-group.

obj-y := dir1/ dir2/ dir3/
obj-m := name.ko
name-objs = foo.o dir1/lib.a dir2/lib.a dir3/lib.a
LDFLAGS += --start-group # Deal with recursive depens of libraries

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/