Re: DIE_NMI_IPI to oprofile ?

[Björn Steinbrink]

On 2007.06.25 23:51:51 -0700, Amitabha Roy wrote:
> Hi
> 
> >From looking at the default_do_nmi code in traps.c it seems that (at
> least for the non BSP case, with reason=0) the die notifier chain gets
> called with val=DIE_NMI_IPI.
> 
> However in the profile_exceptions_notify_handler we check for DIE_NMI
> (and not DIE_NMI_IPI) to decide if we want to cycle through the
> counters. This seems wrong to me unless I am missing something (which
> must be the case, otherwise this code is broken :).
> 
> Can anyone help me understand this ?

notify_die(DIE_NMI, ...) is also called from nmi_watchdog_tick. So
depending on "reason" you call:

notify_die(DIE_NMI_IPI, ...)
nmi_watchdog_tick(...)
---> notify_die(DIE_NMI, ...)

or just

notify_die(DIE_NMI, ...)

HTH
Björn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/