Re: oops with USB serial irda adapter

From: Chuck Ebbert
Date: Thu Jun 21 2007 - 11:17:15 EST


On 06/20/2007 07:17 PM, Alan Cox wrote:
> On Wed, 20 Jun 2007 18:16:47 -0400
> Chuck Ebbert <cebbert@xxxxxxxxxx> wrote:
>
>> [https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241598]
>>
>> Oops happens here in kernel 2.6.20.11:
>> drivers/usb/serial/ir-usb.c, line 557:
>>
>> /* Notify the tty driver that the termios have changed. */
>> port->tty->ldisc.set_termios(port->tty, NULL);
>>
>> (ldisc.set_termios is NULL)
>
> Yeah the driver is full of bugs - its also broken for the way its
> set_termios tries to play 'guess it the properties have changed' and gets
> speed checks wrong, how it snoops the baud bits and some other stuff it
> does.
>
> If you make it look like a real serial driver it ought to work fine. If
> you've got hardware I can send you test patches ?

I think I can get the bug reporter to test, so go ahead and send patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/