Re: [PATCH] Optimize is_power_of_2().

From: David M. Lloyd
Date: Fri Jun 15 2007 - 15:54:52 EST


On Fri, 15 Jun 2007 21:47:50 +0200 (CEST)
Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> wrote:

> On Jun 15 2007 18:56, Vegard Nossum wrote:
> > bool is_power_of_2(unsigned long n)
> > {
> >- return (n != 0 && ((n & (n - 1)) == 0));
> >+ return n * !(n & (n - 1));
> > }
>
> There is a third way which uses neither * nor &&, but []:

I assume using something GCC-specific is right out?

bool is_power_of_to(unsigned long n)
{
return __builtin_ffsl(n) == 1;
}

- DML
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/