Re: [PATCH 1/18] splice: abstract out actor data

From: Jens Axboe
Date: Tue Jun 12 2007 - 12:24:47 EST


On Tue, Jun 12 2007, Eric Dumazet wrote:
> On Tue, 12 Jun 2007 08:57:57 +0200
> Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
>
>
> > + struct splice_desc sd = {
> > + .total_len = len,
> > + .flags = flags,
> > + .pos = *ppos,
> > + };
> > +
> > + sd.file = out;
>
> minor remark, why sd.file is setup differently than other fields ?
>
> (this several times on this patch)

yeah, it's inside an anonymous union, and apparently gcc doesn't like it
being initialized that way.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/