Re: [patch-mm 06/23] clockevents: Fix resume logic

From: Thomas Gleixner
Date: Sun Jun 10 2007 - 05:51:51 EST


On Sun, 2007-06-10 at 19:43 +1000, Nigel Cunningham wrote:
> Hi Thomas.
>
> On Sun, 2007-06-10 at 09:44 +0000, Thomas Gleixner wrote:
> > plain text document attachment (clockevents-fix-resume-logic.patch)
> > We need to make sure, that the clockevent devices are resumed, before
> > the tick is resumed. The current resume logic does not guarantee this.
> >
> > Add CLOCK_EVT_MODE_RESUME and call the set mode functions of the clock
> > event devices before resuming the tick / oneshot functionality.
> >
> > Fixup the existing users.
>
> What are the implications of the issue for current (i386) users? (Could
> suspend/hibernation be broken in any way without this patch?)

I have one box, which needs this patch.

OTOH it breaks Andrew's jinxed VAIO in a very mysterious way:
http://lkml.org/lkml/2007/6/9/158

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/