Re: [PATCH 1/2] [RFC] PCI: read revision ID by default
From: David Miller
Date: Sat Jun 09 2007 - 04:03:09 EST
From: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>
Date: Sat, 9 Jun 2007 00:59:53 -0600
> On Fri, Jun 08, 2007 at 03:46:30PM -0700, Auke Kok wrote:
> > Currently there are 97 occurrences where drivers need the pci
> > revision ID. We can do this once for all devices. Even the pci
> > subsystem needs the revision several times for quirks. The extra
> > u8 member pads out nicely in the pci_dev struct.
> Good idea. I always wondered why we read the invariants so often
> in the code.
BTW, if you add code like this, you also have to add the
appropriate code to do this for all the platforms that probe
the PCI bus using a firmware device tree like sparc64
and powerpc do.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/