Re: [PATCH 0/30] Use menuconfig objects

From: Sam Ravnborg
Date: Wed Apr 11 2007 - 13:30:34 EST


On Wed, Apr 11, 2007 at 06:53:37PM +0200, Stefan Richter wrote:
> Jan Engelhardt wrote:
> > On Apr 11 2007 07:42, Al Boldi wrote:
> >>Also, I don't think it's necessary to touch any of the "depends on"; keep
> >>them as is, as they don't hurt staying that way, and may actually be
> >>necessary under certain circumstances. (see EMBEDDED)
> >
> > Simplifying the depends lines is a good thing IMO.
>
> If explicit dependency statements are replaced by if--endif blocks, does
> this count as simplification?
Applied with some common sense - yes.
if --endif blocks has been used in several places to make dependencies consistent.
When cleaning up the net part I recall a few places where the explicit dependency
was missing causing 1) dependencies to be wrong and 2) caused indention in menu-
config to be wrong.

But yet agin do not go and replace all dependencies with if--endif blocks.
They shall be used with some good taste.


Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/