Re: [PATCH 0/30] Use menuconfig objects

From: Jan Engelhardt
Date: Wed Apr 11 2007 - 13:06:47 EST



On Apr 11 2007 18:53, Stefan Richter wrote:
>Jan Engelhardt wrote:
>> On Apr 11 2007 07:42, Al Boldi wrote:
>>>Also, I don't think it's necessary to touch any of the "depends on"; keep
>>>them as is, as they don't hurt staying that way, and may actually be
>>>necessary under certain circumstances. (see EMBEDDED)
>>
>> Simplifying the depends lines is a good thing IMO.
>
>If explicit dependency statements are replaced by if--endif blocks, does
>this count as simplification?

According to Documentation/kbuild/, if FOO .. endif is interpreted as if
each option inside the if block had 'depends on FOO'.

If _every_ option under a menu (and that's another reason why I did not
modify _all_ Kconfig menus) has a 'depends on this or that', it can
be substituted by an if block, and yes, I take that as a simplification
since the whole LoC count goes down. What would perhaps be cool is
some indent in Kconfig to see what an if-endif block spans, but currently
this is not much needed, since two nested ifs are quite the max.

Jan
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/