Re: [RFC] pata_icside driver

From: Russell King
Date: Mon Apr 09 2007 - 07:36:49 EST


On Mon, Apr 09, 2007 at 07:13:05AM -0400, Jeff Garzik wrote:
> It should be noted, mainly for russell's benefit, that the ->irq_ack()
> hook is only called if a debug define is manually enabled in libata.h,
> in a single callsite.
>
> The number of people that actually use the hook -- kernel hackers
> debugging screaming interrupts -- can probably be counted on one hand.

Ok, in that case it makes sense for me to set this to ata_dummy_irq_ack
since I don't have any additional status registers specific to the
interface.

Presumably a similar change to pata_platform.c would be appropriate?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/