Re: [ckrm-tech] [PATCH 1/7] containers (V7): Generic containersystem abstracted from cpusets code

[Paul Jackson]

vatsa wrote:
> >         if (tsk->flags & PF_EXITING) {
> 
> What if PF_EXITING is set after this check? If that happens then,
> 
> >                 task_unlock(tsk);
> >                 mutex_unlock(&callback_mutex);
> >                 put_task_struct(tsk);
> >                 return -ESRCH;
> >         }
> 
> the following code becomes racy with cpuset_exit() ...
> 
>         atomic_inc(&cs->count);
>         rcu_assign_pointer(tsk->cpuset, cs);
>         task_unlock(tsk);

eh ... so ... ?

I don't know of any sequence where that causes any problem.

Do you see one?

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/