Re: [PATCH 1/7] Introduce the pagetable_operations and associatedhelper macros.

From: Nick Piggin
Date: Wed Mar 21 2007 - 19:04:24 EST


Christoph Hellwig wrote:
On Wed, Mar 21, 2007 at 10:17:40AM -0500, Adam Litke wrote:

Also, it is going to be hugepage-only, isn't it? So should the naming be
changed to reflect that? And #ifdef it...

They are doing some interesting things on Cell that could take advantage
of this.


That would be new to me. What we need on Cell is fixing up the
get_unmapped_area mess which Ben is working on now.

And let me once again repeat that I don't like this at all. I'll
rather have a few ugly ifdefs in strategic places than a big object
oriented mess like this with just a single user.

I think I agree that we'd need more than one user for this.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/