Re: [PATCH 1/7] Introduce the pagetable_operations and associatedhelper macros.

[Nick Piggin]

Adam Litke wrote:
> On Wed, 2007-03-21 at 15:18 +1100, Nick Piggin wrote:
>
> > Adam Litke wrote:

> > > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > > index 60e0e4a..7089323 100644
> > > --- a/include/linux/mm.h
> > > +++ b/include/linux/mm.h
> > > @@ -98,6 +98,7 @@ struct vm_area_struct {
> > >
> > > 	/* Function pointers to deal with this struct. */
> > > 	struct vm_operations_struct * vm_ops;
> > > +	const struct pagetable_operations_struct * pagetable_ops;
> > >
> > > 	/* Information about our backing store: */
> > > 	unsigned long vm_pgoff;		/* Offset (within vm_file) in PAGE_SIZE
> >
> > Can you remind me why this isn't in vm_ops?
>
>
> We didn't want to bloat the size of the vm_ops struct for all of its
> users.

But vmas are surely far more numerous than vm_ops, aren't they?

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/