Re: [PATCH -mm 1/4] Blackfin: architecture update patch

From: Mike Frysinger
Date: Wed Mar 21 2007 - 11:39:43 EST


On 3/21/07, Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
On Wed, Mar 21, 2007 at 06:06:58PM +0800, Wu, Bryan wrote:
> +++ linux-2.6/arch/blackfin/Kconfig 2007-03-21 14:38:42.000000000 +0800
> +config BLACKFIN
> config BFIN

Again, there's no reason to have both of these. Pick one and stick with
it.

we're working on it ... not everything has been converted yet, thus
they're still both alive :/

> +/* CSYNC implementation for C file */
> #if defined(ANOMALY_05000312) && defined(ANOMALY_05000244)

Is there some reason these aren't config options? Perhaps an errata
sub-menu might be more intuitive.

there is ... in the Kconfig, you select the CPU and the silicon
version ... we then have a header file that determines which anomalies
need to be worked around since the anomaly/silicon binding is static
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/