Re: + remove-the-likelypid-check-in-copy_process.patch added to -mm tree

From: Eric W. Biederman
Date: Sat Mar 17 2007 - 14:55:48 EST


Oleg Nesterov <oleg@xxxxxxxxxx> writes:

> Yes! I meant we should change INIT_SIGNALS(), currently it does
>
> #define INIT_SIGNALS(sig) {
> ...
> .pgrp = 1,
> { .__session = 1},
>
> and this confuses (I think) set_special_pids(1,1) above. Because
> __set_special_pids() still deals with pid_t, not "struct pid".
>
> Unless I missed something, we should kill these 2 initializations
> above.

Got it. I agree we should initialize those fields to 0.

Sukadev you want to get that?

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/