Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistentlymark no-op operations

From: Jeremy Fitzhardinge
Date: Fri Mar 16 2007 - 14:44:06 EST


Ingo Molnar wrote:
> but only as a cleanup of the current open-coded (void *) casts. My
> problem with this is that it loses the types. Not that there is much to
> check for, but still, this adds some assumptions about how function
> calls look like.

I agree. I don't generally like this kind of hack, but having a single
test for "func == paravirt_nop" to look for nop pv_ops in the patcher is
what tipped the balance.

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/