Re: [PATCH] Broadcom 4400 resume small fix

From: Francois Romieu
Date: Mon Jan 08 2007 - 16:03:45 EST


Dmitriy Monakhov <dmonakhov@xxxxx> :
> Return value of 'pci_enable_device' was ignored in b44_resume().
> We can't ingore it because it can fail.

- Please Cc: netdev@xxxxxxxxxxxxxxx, jeff@xxxxxxxxxx and the maintainer
of the driver (Gary Zambrano <zambrano@xxxxxxxxxxxx> as per MAINTAINERS
file and the log of the driveri).
- the dev_err() message fits completely on a 80 columns line.
- request-irq is not checked a few lines below either.

It would be nice to avoid the free_irq/pci_disable_device dance altogether.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/