Re: sata badness in 2.6.20-rc1? [Was: Re: md patches in -mm]

[Andrew Morton]

On Tue, 19 Dec 2006 15:26:00 -0800 (PST)
Luben Tuikov <ltuikov@xxxxxxxxx> wrote:

> The reason was that my dev tree was tainted by this bug:
> 
>         if (good_bytes &&
> -           scsi_end_request(cmd, 1, good_bytes, !!result) == NULL)
> +           scsi_end_request(cmd, 1, good_bytes, result == 0) == NULL)
>                 return;
> 
> in scsi_io_completion().  I had there !!result which is wrong, and when
> I diffed against master, it produced a bad patch.

Oh.  I thought that got sorted out.  It's a shame this wasn't made clear to
me..

> As James mentioned one of the chunks is good and can go in.

Please send a new patch, not referential to any previous patch or email,
including full changelogging.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/