Re: sata badness in 2.6.20-rc1? [Was: Re: md patches in -mm]

[Luben Tuikov]

--- thunder7@xxxxxxxxx wrote:
> From: Andrew Morton <akpm@xxxxxxxx>
> Date: Sun, Dec 17, 2006 at 03:05:39AM -0800
> > On Sun, 17 Dec 2006 12:00:12 +0100
> > "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> > 
> > > Okay, I have identified the patch that causes the problem to appear, which is
> > > 
> > > fix-sense-key-medium-error-processing-and-retry.patch
> > > 
> > > With this patch reverted -rc1-mm1 is happily running on my test box.
> > 
> > That was rather unexpected.   Thanks.
> >
> I can confirm that 2.6.20-rc1-mm1 with this patch reverted mounts my
> raid6 partition without problems. This is x86_64 with SMP.
> 

The reason was that my dev tree was tainted by this bug:

        if (good_bytes &&
-           scsi_end_request(cmd, 1, good_bytes, !!result) == NULL)
+           scsi_end_request(cmd, 1, good_bytes, result == 0) == NULL)
                return;

in scsi_io_completion().  I had there !!result which is wrong, and when
I diffed against master, it produced a bad patch.

As James mentioned one of the chunks is good and can go in.

    Luben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/