Re: S2RAM and PCI quirks

From: Alan Cox
Date: Wed Nov 08 2006 - 10:57:33 EST


Ar Mer, 2006-11-08 am 16:48 +0100, ysgrifennodd Arjan van de Ven:
> at the same time I'm not 100% convinced it's ok to always run all quirks
> at resume, for one the difference is that there now is a driver active
> owning the device... Almost sounds like having a per quirk flag stating
> "run at resume" is needed ;-(

We probably need a quirk class for resume in this situation. The kind of
things that worry me if we are not doing the quirk handling, and what I
suspect happened in the case I looked at are that chipset bug
workarounds did not get restored, and in this case the older VIA chipset
involved then corrupted DMA streams and trashed the users disk.

> (also I think the quirks are currently __init but that's relatively easy
> to fix)

Some are yes, but not others.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/