Re: S2RAM and PCI quirks

From: Arjan van de Ven
Date: Wed Nov 08 2006 - 10:49:08 EST


On Wed, 2006-11-08 at 15:45 +0000, Alan Cox wrote:
> I'm tracing down a case where suspend to ram/resume from RAM causes
> horrible corruption but not immediately. From a PCI dump it appears that
> we are not running the PCI quirks again on the S2RAM resume. Is this
> actually the case or am I missing something scanning through the code.
> If it is the case then we have multiple corruptors lurking because the
> PCI config restore doesn't cover the special registers that need poking
> in some cases.

at the same time I'm not 100% convinced it's ok to always run all quirks
at resume, for one the difference is that there now is a driver active
owning the device... Almost sounds like having a per quirk flag stating
"run at resume" is needed ;-(

(also I think the quirks are currently __init but that's relatively easy
to fix)

--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/