Re: [patch 1/1] watchdog driver for Digital-Logic MSM-P5XEN PC104unit

[Alan Cox]

Ar Maw, 2006-10-17 am 12:34 +0000, ysgrifennodd ggaleotti@xxxxxxxxxxxx:
> +static void
> +wdt_enable(unsigned long data)
> +{
> +	(void)data;
> +
> +	outb(inb(io_base + WDT_OFFSET) & 0xf7, io_base + WDT_OFFSET);
> +}
> +

If you don't need "data" why pass it ?



No locking against parallel close/open
No no-way-out lock implementation
Short many of the standard ioctls it could and should implement (eg
timeout get)

NAK for now although it just needs tidying and expanding out a little to
be a good driver.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/