Re: [PATCH] SCSI/qla2xxx: handle sysfs errors

[Andrew Vasquez]

On Thu, 12 Oct 2006, Jeff Garzik wrote:

> Andrew Vasquez wrote:
> >NACK, please don't do this.  SYSFS entries, albiet important, aren't
> >necessarilly critical to a functioning driver.  I'd rather the driver
> >not error out.
> 
> As discussed before, the only errors thrown are either ENOMEM or EFAULT, 
> both of which are quite serious.

Absolutely.  But, given the relatively late-stage initialization of
these attributes (it's the last thing that gets done before probe()
completes)-- the driver has already allocated (successfully) memory,
intialized hardware and (possibly) presented storage, the complete
unwinding, seems over-kill.

> >Here's what I had stewing to address the must_check directives and
> >qla2xxx:
> 
> If you're gonna change it that much, might as well use attribute groups.

sysfs_create_group() and friends don't appear to support
binary attributes.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/